fix(i18n): wrap original error in i18n#1198
Closed
Haroka-74 wants to merge 1 commit intofloatpane:masterfrom
Closed
fix(i18n): wrap original error in i18n#1198Haroka-74 wants to merge 1 commit intofloatpane:masterfrom
Haroka-74 wants to merge 1 commit intofloatpane:masterfrom
Conversation
floatpanebot
previously requested changes
Apr 29, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @Haroka-74! Please fix the following issues with your PR:
- Title: Is too long (47 characters). The PR title must be strictly under 40 characters.
Haroka-74
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaced the
%vverb with%wini18n/parser.gowhen returning errors from the parser.Why?
The previous implementation only wrapped
ErrParseFailed. By rendering the underlying err as a string (%v), the error chain was broken. This prevented callers from usingerrors.Is()orerrors.As()to detect the original cause of the failure. Using double%w(supported in Go 1.20+) ensures both the sentinel error and the root cause remain accessible in the error tree.Closes #1050